Skip to content

3.10 Compatibility Patch#84

Open
DJStompZone wants to merge 2 commits intopyreadline:masterfrom
DJStompZone:collections-3.10-patch
Open

3.10 Compatibility Patch#84
DJStompZone wants to merge 2 commits intopyreadline:masterfrom
DJStompZone:collections-3.10-patch

Conversation

@DJStompZone
Copy link

Summary

Made a small adjustment to py3k_compat to allow pyreadline to be imported without issue on Python versions 3.10 or greater.

Details

  • Thorough testing to ensure correct functionality for Python 3.10+ while maintaining back-compatibility.
  • Applied necessary modifications to maintain backward compatibility with older Python versions.

Issues Fixed

Testing

Python package

  • Tested on Python 3.6 - 3.13 to verify import functionality.
  • Confirmed that the changes do not affect older Python versions.

Fix the error encountered while importing collections.Callable on 3.10+
Ensure compatibility with Python 2 and Python 3.10+
Copy link
Author

@DJStompZone DJStompZone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@brokedarius
Copy link

brokedarius commented Jun 24, 2024

I was about to mention the exact same thing but I just installed pyreadline today and it seems it's still on the old code where it imports collections instead of collections.abc so we still get that error on the 'Callable' attribute.

I am quite sure I did not have pyreadline installed before because at first I typed uninstall by mistake and it told me that it was not installed.

@DJStompZone
Copy link
Author

Well it's not looking like this is getting merged any time soon... Considering I've been using my own fork these past few months and it has entirely eliminated the issue and proven to be quite stable otherwise, I've taken the liberty of publishing a release which fixes compatibility with modern versions of python and adds support for PEP 517 installs via pyproject.toml

Anyone interested in doing so can feel free to use this version as well.

Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants