Handling Collections Callable Attribute missing issue in 3.9+#81
Open
udhayprakash wants to merge 1 commit intopyreadline:masterfrom
Open
Handling Collections Callable Attribute missing issue in 3.9+#81udhayprakash wants to merge 1 commit intopyreadline:masterfrom
udhayprakash wants to merge 1 commit intopyreadline:masterfrom
Conversation
In python 3.11, when working on a module, I got below error.
\pyreadline\py3k_compat.py", line 8, in callable return isinstance(x, collections.Callable)
^^^^^^^^^^^^^^^^^^^^
AttributeError: module 'collections' has no attribute 'Callable'
When researched I understood that Collections module was modified. It moved collections.Callable to collections.abc.Callable
Handled that change, bearing in mind backward compatibility
|
Hello, can you push this modification on pip please. I use the May I suggest this code instead : def callable(x):
if sys.version_info[1] >= 10:
return isinstance(x, collections.abc.Callable)
else:
return isinstance(x, collections.Callable) |
Author
|
i dont have permissions to merge this PR. I, too, am awaiting for the repo owner to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In python 3.11, when working on a module, I got below error.
\pyreadline\py3k_compat.py", line 8, in callable return isinstance(x, collections.Callable)
^^^^^^^^^^^^^^^^^^^^
AttributeError: module 'collections' has no attribute 'Callable'
When researched I understood that Collections module was modified. It moved collections.Callable to collections.abc.Callable Handled that change, bearing in mind backward compatibility