changed structure to redefine axis via plotitem.setAxes#391
changed structure to redefine axis via plotitem.setAxes#391j9ac9k merged 5 commits intopyqtgraph:developfrom
Conversation
plotitem.setAxes
Current coverage is 34.08% (diff: 89.47%)@@ develop #391 diff @@
==========================================
Files 198 198
Lines 27249 27254 +5
Methods 0 0
Messages 0 0
Branches 4568 4569 +1
==========================================
+ Hits 9280 9289 +9
+ Misses 17143 17140 -3
+ Partials 826 825 -1
|
| self.plot(**kargs) | ||
|
|
||
|
|
||
| def setAxes(self, axisItems): |
There was a problem hiding this comment.
if self.axes is actually non empty when this method is called, should not they be removed from the layout before adding the new axes?
There was a problem hiding this comment.
you are right. changed that. see last commit.
|
OK, good to me. Do you agree @campagnola and @ericdill ? |
NEW AxisItem.setOrientation (needed by plotitem.setAxes) show/hide right axes after .setAxes()
| self.label.setRotation(-90) | ||
| if self.orientation: | ||
| self._updateWidth() | ||
| self.setMaximumHeight(16777215) |
There was a problem hiding this comment.
this restores origin value
|
setAxes should work now as expected to try out this PR, please modify 'PlotWidget' example as follows: ORIGINAL: WITH ADDED CODE BEFORE LINE 'def rand(n):' WITH ADDED COSE BEFORE LINE 'def rand(n):' |
|
Thanks for the PR @radjkarl LTGM, merging, sorry it's taken so long for us to get to this. |
|
Going to revert this PR due to some incompatibilities with PRs merged after this PR was created. |
this allows to redefine the plotItems axes after creation.