Fixed bug that significantly degraded zooming performance for line plots#3330
Merged
j9ac9k merged 1 commit intopyqtgraph:masterfrom Jun 27, 2025
Merged
Fixed bug that significantly degraded zooming performance for line plots#3330j9ac9k merged 1 commit intopyqtgraph:masterfrom
j9ac9k merged 1 commit intopyqtgraph:masterfrom
Conversation
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed when going from the latest stable release (13.7) to the development version, that the performance of zooming in a large line plot (using peak auto-downsampling, but I'm unsure if that was relevant) was significantly worse.
By binary searching commits for the issue, I found that it occured after commit no d13e2ce, which should be purely about documentation and linting.
The offending line caused "all_finite" to never be updated, and stay as None forever.