keep track of respective finiteness of x and y#2720
Merged
j9ac9k merged 1 commit intopyqtgraph:masterfrom May 16, 2023
Merged
Conversation
integer types are always finite, no need to check for backwards compatibility, "containsNonfinite" is converted to a property.
Member
|
Thanks @pijyoi this LGTM. Love the diff; and I agree checking each x and y independently is the way to go. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A common plotting case is when "x" is provided as integers.
This also happens when only "y" is specified, in which case "x" is automatically populated as
np.arange(len(y)).In this case, it is wasteful to check the finiteness of "x".
In implementing this PR, it was found to be more useful to keep track of the finiteness of
xandyarrays separately.