fix: isnan is not available in OpenGL 2.1 nor OpenGL ES 2.0#3248
Merged
j9ac9k merged 2 commits intopyqtgraph:masterfrom Feb 21, 2025
Merged
fix: isnan is not available in OpenGL 2.1 nor OpenGL ES 2.0#3248j9ac9k merged 2 commits intopyqtgraph:masterfrom
j9ac9k merged 2 commits intopyqtgraph:masterfrom
Conversation
it is available in OpenGL 3.0 (GLSL 130) and OpenGL ES 3.0
required for OpenGL ES
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#3170 added checks for
nanin the shader code.The "COMPAT" shader code is intended for running on OpenGL 2.1 and OpenGL ES 2.0, and in those versions,
isnanis not defined. Fix by replacingisnanwith a self comparison.Notes:
isnandoesn't trigger an error. An error is only triggered if the GLSL version is explicitly specified as#version 120. i.e. the shader compiler can be permissive and support functions that appear in newer GLSL versions.A simple script to exercise the shader code.