pcmi opengl: discard nan fragments#3170
Merged
j9ac9k merged 1 commit intopyqtgraph:masterfrom Oct 24, 2024
Merged
Conversation
Member
|
Thanks @pijyoi for this PR. This LGTM, merging! |
Contributor
Author
|
With regard to whether edges of nan cells should be rendered,
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#3114 defined nan values in PCMI to be transparent.
Update the OpenGL code-path to have the same behavior.
What this PR doesn't do:
Arguably, the non-OpenGL code-path behavior was just an accident. Either behavior makes sense.
Sample code adapted from #3090 to demonstrate nan pixels being transparent.