GraphicsLayout: Fix removeItem() regression#3226
Conversation
This fixes a regression introduced in 54efcbd, where the stretch factors for the row/column previously containing a removed item were zeroed. In general, this is of course incorrect, as there will be other items sharing the same row/column that should not be disturbed. The intention behind that part of the change is not clear to me; this commit simply reverts it.
|
Test failures are unrelated to this PR. |
|
@j9ac9k: Apologies to ping you, but since you merged the PR introducing this regression, I was hoping you could have a quick look. The regression affects all pyqtgraph applications using |
|
Hi @dnadlinger Sorry it's taken me so long to get to this. When it comes to undoing PRs (to address regressions), I try and test more carefully to ensure the original issue is addressed as well as the bug from the initial fix. Can you submit a reproducible example that I can use to work from? Thanks. |
|
Closing/Opening to trigger a new CI run. |
|
Ugh, who merged that change 🙃 The other PR doesn't actually recover the space either... Thanks for the fix @dnadlinger |
This fixes a regression introduced in
54efcbd, where the stretch factors for the row/column previously containing a removed item were zeroed. In general, this is of course incorrect, as there will be other items sharing the same row/column that should not be disturbed. The intention behind that part of the change is not clear to me; this commit simply reverts it.
Fixes #3195.