Update removeItem()#3167
Merged
j9ac9k merged 1 commit intopyqtgraph:masterfrom Oct 24, 2024
psyuktha:removeItem
Merged
Conversation
As addressed in issue #3085 After removing the item, explicitly adjusted the row and column stretches to ensure the layout resizes correctly.
Contributor
Author
|
@j9ac9k could you please review the changes done? |
Member
|
@psyuktha I appreciate your enthusiasm in contribution to the library, but please keep in mind that I
My time to review PRs (or possibly write code) for the library may not match up with that of contributors. Pinging me every ~12 hours isn't going to get me to merge your PR any faster than otherwise, and it will just make me dread checking my notifications for greater detail. |
Member
|
Thanks for the PR @psyuktha this LGTM, merging! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As addressed in issue #3085
After removing the item, explicitly adjusted the row and column stretches to ensure the layout resizes correctly.
Key changes to the function are: