PlotDataItem setData() listOfDicts fix?#3190
Merged
j9ac9k merged 4 commits intopyqtgraph:masterfrom Jan 25, 2025
Merged
Conversation
set output char format to self.ouput.font for consistency set input font to be the same as the output font for consistency drop "TypeWriter" style hint, it seems to map to "American Typewriter" on macos, which is not fixed-width...
Member
|
You're absolutely right. Huh, this code is ancient (git blame says from 13 years ago!) ...how did this get avoided for so long! Nice find! |
j9ac9k
pushed a commit
to j9ac9k/pyqtgraph
that referenced
this pull request
Mar 25, 2025
* output char formats needs to be set or it can have some random font set output char format to self.ouput.font for consistency set input font to be the same as the output font for consistency drop "TypeWriter" style hint, it seems to map to "American Typewriter" on macos, which is not fixed-width... * delete comment * I think this should be data[0], same handling as as 'x' and 'y'...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's entirely possible I'm confused here, but the way it is now, 'data' (etc) would have to be in the list
data, but then a string isn't a dict and the list interpretation fails...So I think it should be
if k in data[0], notif k in data, in other words, the same handling as'x'and'y'.I should have merged first, but see commit 369a751 for the code change...
Otherwise, any help appreciated!
Thanks,
Kevin