Merged
Conversation
j9ac9k
reviewed
Nov 1, 2024
j9ac9k
reviewed
Nov 1, 2024
Member
|
Thanks for the PR, this LGTM; I just had a couple of nit-picks which I commented. |
Contributor
Author
|
Latest commit available with updates per your feedback, thank you! |
Member
|
Thanks @kevinanewman for updating the PR, sorry it's taken me so long to get to this! |
j9ac9k
pushed a commit
to j9ac9k/pyqtgraph
that referenced
this pull request
Mar 25, 2025
* add setSymbol method * Update docstring and reformat KeyError string
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add setSymbol method to TargetItem
Allows symbol to be updated after TargetItem is created, which can be used to create user-editable or dynamic targets.
Updated error message for unknown string type symbols.