ParseError line numbers should account for empty lines#3131
Merged
j9ac9k merged 6 commits intopyqtgraph:masterfrom Aug 21, 2024
Merged
ParseError line numbers should account for empty lines#3131j9ac9k merged 6 commits intopyqtgraph:masterfrom
j9ac9k merged 6 commits intopyqtgraph:masterfrom
Conversation
- blank/comment lines are already excluded from processing on line 140 - test new behavior
Contributor
Author
|
|
Contributor
Author
|
|
Member
|
This module needs to die... python already offers a config parser and tomllib (in python 3.11), which I would be happy to add support for. I'll merge this but I'm >< close to slapping a deprecation warning for some point a year+ out. |
j9ac9k
pushed a commit
to j9ac9k/pyqtgraph
that referenced
this pull request
Mar 25, 2025
* style improvements: whitespace, f-strings * keep line numbers consistent with whitespace and comments - blank/comment lines are already excluded from processing on line 140 - test new behavior * chain exceptions when possible * make sure only real lines are used to measure indentation * underscore unused variable * under-indented comments should not be treated as ending a data structure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Comments and blank lines were already being skipped during line processing, so we don't need to pre-exclude them. Doing so impacted the accuracy of the ParseErrors. Test included. General style improvements and python-3-isms also added.