Raise ParseError on duplicate keys in configfile#3121
Merged
j9ac9k merged 2 commits intopyqtgraph:masterfrom Aug 7, 2024
Merged
Raise ParseError on duplicate keys in configfile#3121j9ac9k merged 2 commits intopyqtgraph:masterfrom
j9ac9k merged 2 commits intopyqtgraph:masterfrom
Conversation
outofculture
commented
Aug 6, 2024
| #print "Going deeper..", ln+1 | ||
| (ln, val) = parseString(lines, start=ln+1, **scope) | ||
| if k in data: | ||
| raise ParseError(f'Duplicate key: {k}', ln+1, l) |
Contributor
Author
There was a problem hiding this comment.
Here's the only substantive change.
Member
|
"Thanks, I hate it" (not referring to your PR, but supporting our own config file 😆 ) |
j9ac9k
pushed a commit
to j9ac9k/pyqtgraph
that referenced
this pull request
Mar 25, 2025
* raise ParseError when configfiles have duplicate keys * style improvements while looking around
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Maybe we shouldn't really be maintaining our own config file format, but since we're doing so anyway, here's a behavior we should have.
This includes some minor style updates, as well, which my editor demanded I make before it would let me edit the code (I kid).