Skip to content

Fixup 3007#3008

Merged
j9ac9k merged 1 commit intopyqtgraph:masterfrom
j9ac9k:fix-mistake-in-3007
Apr 28, 2024
Merged

Fixup 3007#3008
j9ac9k merged 1 commit intopyqtgraph:masterfrom
j9ac9k:fix-mistake-in-3007

Conversation

@j9ac9k
Copy link
Copy Markdown
Member

@j9ac9k j9ac9k commented Apr 28, 2024

Re-add commented out tests in #3007

@j9ac9k j9ac9k force-pushed the fix-mistake-in-3007 branch 6 times, most recently from 76267ba to 1963899 Compare April 28, 2024 14:22
@j9ac9k j9ac9k force-pushed the fix-mistake-in-3007 branch 3 times, most recently from 8552c6b to d01055e Compare April 28, 2024 14:45
In some rare occasions in CI, try_fastpath_argb would trigger a segfault

Since this function pre-dates functions_qimage.try_make_qimage, we can
retire this function with minimal impact to end users.

Furthermore, uncomment out the tests that were commented out in pyqtgraph#3007
@j9ac9k j9ac9k force-pushed the fix-mistake-in-3007 branch from d01055e to f304731 Compare April 28, 2024 16:33
@j9ac9k j9ac9k merged commit e200849 into pyqtgraph:master Apr 28, 2024
@j9ac9k j9ac9k deleted the fix-mistake-in-3007 branch April 28, 2024 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants