Add note about NaN to int conversion#3007
Conversation
Disable some assert checks due to variance across platforms
|
heh, did this PR resolve the segfault? |
|
I don't think this PR is correct. The nan-to-int casting has to do with the resultant R,G,B values. e.g. assuming levels=(0, 1); if a particular input pixel had values [1.0, nan, 0.5], The failing tests had the assumption that |
|
ahh, test suite doesn't check any of the RGB value here that have NaN's ... suppose I'll try a little bit more to try and see if I can figure out where the segfault in the |
In some rare occasions in CI, try_fastpath_argb would trigger a segfault Since this function pre-dates functions_qimage.try_make_qimage, we can retire this function with minimal impact to end users. Furthermore, uncomment out the tests that were commented out in pyqtgraph#3007
In some rare occasions in CI, try_fastpath_argb would trigger a segfault Since this function pre-dates functions_qimage.try_make_qimage, we can retire this function with minimal impact to end users. Furthermore, uncomment out the tests that were commented out in pyqtgraph#3007
In some rare occasions in CI, try_fastpath_argb would trigger a segfault Since this function pre-dates functions_qimage.try_make_qimage, we can retire this function with minimal impact to end users. Furthermore, uncomment out the tests that were commented out in pyqtgraph#3007
Fixes #2969