Skip to content

speed up PColorMeshItem#2768

Merged
j9ac9k merged 3 commits intopyqtgraph:masterfrom
pijyoi:pcmi-groupby-coloridx
Jul 8, 2023
Merged

speed up PColorMeshItem#2768
j9ac9k merged 3 commits intopyqtgraph:masterfrom
pijyoi:pcmi-groupby-coloridx

Conversation

@pijyoi
Copy link
Copy Markdown
Contributor

@pijyoi pijyoi commented Jul 7, 2023

By applying some of the techniques implemented in #2764, some speed up to PCMI has been obtained.

To make the speed up measurable, the example was modified to use FrameCounter.
This is not quite the same behavior as the original code, which was trying to cap the animation to 25 fps.

@pijyoi pijyoi force-pushed the pcmi-groupby-coloridx branch 2 times, most recently from 6ba71b3 to 9bd4f0c Compare July 8, 2023 04:16
@pijyoi pijyoi force-pushed the pcmi-groupby-coloridx branch from 9bd4f0c to 2ac154a Compare July 8, 2023 05:07
@pijyoi pijyoi marked this pull request as ready for review July 8, 2023 05:12
@j9ac9k
Copy link
Copy Markdown
Member

j9ac9k commented Jul 8, 2023

Thanks @pijyoi

I'm loving the impact the FrameCounter is having on simplifying our examples even more.

@j9ac9k j9ac9k merged commit 71bcf3f into pyqtgraph:master Jul 8, 2023
@pijyoi pijyoi deleted the pcmi-groupby-coloridx branch July 8, 2023 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants