Merged
Conversation
j9ac9k
reviewed
Jul 6, 2023
| self.update() | ||
|
|
||
| x, y, z = self.data | ||
| def getLevels(self): |
Member
There was a problem hiding this comment.
Could this be renamed to just levels() (with setLevels() being the setter)?
Contributor
Author
There was a problem hiding this comment.
ColorBarItem is looking for getLevels. To change to "levels()" would require corresponding changes to ColorBarItem, ImageItem, PColorMeshItem, HistogramLUTItem.
Member
There was a problem hiding this comment.
Outside the scope of this PR to change all those other objects, but I'd like to deprecate that at point; but that's a future issue 👍
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Behavior changes:
NonUniformImage::setLookupTablewas previously implemented to take in aHistogramLUTItem. Now it takes in a numpy array, likeImageItem.Improvements:
NonUniformImagecan be used with bothHistogramLUTItemandColorBarItem, in the same way that anImageItemis used.ColorBarItem. This also removes the hack of inserting a custom colormap intoGradientEditorItem.drawRects. The speed up can be observed with the example atBarGraphItem: calculate boundingRect without drawing #2599 (comment)
Bugs fixed:
HistogramLUTItemwas not usingImageItem::getLevels()accessor