WidgetGroup: avoid lambda by using self.sender()#2694
Merged
j9ac9k merged 2 commits intopyqtgraph:masterfrom May 11, 2023
Merged
WidgetGroup: avoid lambda by using self.sender()#2694j9ac9k merged 2 commits intopyqtgraph:masterfrom
j9ac9k merged 2 commits intopyqtgraph:masterfrom
Conversation
Contributor
Author
|
CI is crashing like for #2671, but now also includes Conda/Ubuntu/PySide2. |
Contributor
Author
|
#2606 bumped conda python from 3.9 to 3.11, skipping 3.10. According to a comment in https://bugreports.qt.io/browse/PYSIDE-1864, Python > 3.10 will not be supported by Qt. |
Contributor
Author
|
#1598 mentions |
Member
|
Thanks @pijyoi ...appreciate the touch-up on the CI, testing python 3.11 with pyside2 does feel silly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
workaround #2672 by avoiding the mechanism triggering the leak in PySide6 6.5.0
WidgetGroupwas creating lambda closures with references to bothselfandwidget.deffunctions (with no closures) also leaksQObject::sender(https://doc.qt.io/qt-6/qobject.html#sender) and avoids the closure.