ViewBoxMenu: remove unused empty WidgetGroup#2671
Closed
pijyoi wants to merge 2 commits intopyqtgraph:masterfrom
Closed
ViewBoxMenu: remove unused empty WidgetGroup#2671pijyoi wants to merge 2 commits intopyqtgraph:masterfrom
pijyoi wants to merge 2 commits intopyqtgraph:masterfrom
Conversation
b45a86f to
9c6e7c4
Compare
Contributor
Author
|
Even though the objects removed in this PR are unused, removing them is reliably making the CI fail for Conda/Windows/PySide2. |
Member
Ugh ... well that sucks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the unused instantiated
WidgetGroups from ViewBoxMenu.In fact, until less than a year ago (74fa36d), the (unused) instantiated
WidgetGroups were not even stored.