inherit GraphicsWidgetAnchor on the left-hand-side#2662
Merged
j9ac9k merged 1 commit intopyqtgraph:masterfrom Mar 25, 2023
Merged
inherit GraphicsWidgetAnchor on the left-hand-side#2662j9ac9k merged 1 commit intopyqtgraph:masterfrom
j9ac9k merged 1 commit intopyqtgraph:masterfrom
Conversation
Member
|
glad this didn't have other consequences like with the docks! Thanks for identifying this issue and submitting a fix @pijyoi merging! |
This was referenced Apr 4, 2023
Closed
Contributor
Author
|
Was contemplating whether we should disinherit |
StSav012
added a commit
to StSav012/psk_viewer
that referenced
this pull request
Apr 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following the merge of https://code.qt.io/cgit/pyside/pyside-setup.git/commit/?id=e8095467f7d0332cc0987e7c541de9906e19fece slated for PySide6 6.5, inheriting
GraphicsWidgetAnchoron the right-hand-side no longer works.In fact, since PyQt{5,6} do implement cooperative inheritance, then the previous implementation of inheriting
GraphicsWidgetAnchoron the right-hand-side would be wrong. i.e.GraphicsWidgetAnchor::__init__was being called twice on PyQt{5,6}. (Indeed, adding simple print statements shows that it was being called twice on PyQt{5,6}There is a
connectstatement inGraphicsWidgetAnchor::__init__, which would make calling it multiple times not harmless.Note:
GraphicsWidgetAnchoras a mixin should be inherited on the left-hand-side.