rename "method" to "use_array" and make it keyword only#2609
Merged
j9ac9k merged 1 commit intopyqtgraph:masterfrom Feb 11, 2023
Merged
rename "method" to "use_array" and make it keyword only#2609j9ac9k merged 1 commit intopyqtgraph:masterfrom
j9ac9k merged 1 commit intopyqtgraph:masterfrom
Conversation
document explicitly however that PrimitiveArray is not public facing API.
Member
|
@pijyoi I really appreciate your work on getting these lower-level interfaces working! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Even though PrimitiveArray is not public facing API, its
__init__argument "method : bool" was not named correctly.This rename was originally meant to be part of #2596, but as #2596 needs more testing, the rename is extracted out to get it in before the next release.