Prepare support for PySide6 drawLines and friends#2596
Prepare support for PySide6 drawLines and friends#2596j9ac9k merged 5 commits intopyqtgraph:masterfrom
Conversation
|
Added re-use of backing memory if new size is smaller than largest previous sizes. |
5207f69 to
e86a164
Compare
872f40b to
12586e8
Compare
8b22e9a to
009fcdc
Compare
|
The re-use of backing memory now also works with the unreleased To exercise this PR more within the CI, a temporary change was made to set |
|
@pijyoi i love this diff, thank you for commenting the Since we just released 0.13.2, I would be good w/ merging this PR (once |
|
PySide 6.5.0 has been released, going to close/re-open this PR to trigger a new CI run. |
|
unrelated to this PR, but looks like we're getting a failure in CI This will need to be addressed before we can test/review this PR. |
|
Closing and Re-Opening again now that Qt 6.5 works in CI. |
|
Looks like CI for pyside 6.5 is green across the board, let's undo the segmentation line check and merge 🎊 |
|
It's already undone |
oh... well, that's silly of me. Thanks for your work on this @pijyoi ! |
As PYSIDE-1924 (https://bugreports.qt.io/browse/PYSIDE-1924) feature has been added, we can prepare pyqtgraph to make use of it when it gets into a released version.
For now, testing can be done with the wheels at https://download.qt.io/snapshots/ci/pyside/dev/latest/
One issue is that PySide6's array API implementation will requirement passing of different arguments than the other codepaths. For this, we add a
drawargs()method.A synthetic benchmark to exercise the new API.