BarGraphItem: implement boundingRect with pen width#2561
Closed
pijyoi wants to merge 1 commit intopyqtgraph:masterfrom
Closed
BarGraphItem: implement boundingRect with pen width#2561pijyoi wants to merge 1 commit intopyqtgraph:masterfrom
pijyoi wants to merge 1 commit intopyqtgraph:masterfrom
Conversation
0072a10 to
fc6a705
Compare
This was referenced Dec 26, 2022
Merged
Contributor
Author
|
closing in favor of #2565 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2550
Related to #2554, #2560
After playing around with thicker pen widths, it turns out that
QPicture.boundingRect()assumes that pens are non-cosmetic; when in fact pyqtgraph usually uses cosmetic pens. This means thatQPicture.boundingRect()adds the pen widths to the bounding rectangle in data sizes rather than in device pixel sizes.A sample script below demonstrates the issue. When a thick pen is used, it results in a lot of empty space.
Not being familiar with the very code that this PR changes, this PR is created as a draft.
master: PyQt6.QtCore.QRectF(-6.0, -3.0, 17.0, 69.0)

this PR: PyQt6.QtCore.QRectF(-3.082433908183643, -0.6809981495366643, 11.164867816367286, 67.36199629907333)
