compute floating point boundingRect#2554
Merged
j9ac9k merged 1 commit intopyqtgraph:masterfrom Dec 14, 2022
Merged
Conversation
Member
|
Oh no, are we going to have to generate new test images? |
49a9bfb to
9e126fb
Compare
Contributor
Author
No, there was some self-referencing in |
Member
|
This LGTM, thanks @pijyoi ! |
Contributor
Author
|
Hmm, the bounding rectangle computed this way ignores the pen width. Practically speaking, it doesn't seem to cause a problem. It doesn't seem easy to incorporate the pen width into the bounding rectangle, as the pen width is in device pixels. |
This was referenced Dec 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2550
A few
GraphicsItems compute their bounding rectangle withQPicture::boundingRect() -> QRect, probably following the example incustomGraphicsItem.py. This causes issues when the data limits exceed the int32 range of aQRect.This PR fixes the cases where the bounding rectangle can be easily built up from the drawing primitives used.