fix wrong logic for assert_alldead#2503
Merged
j9ac9k merged 1 commit intopyqtgraph:masterfrom Oct 26, 2022
Merged
Conversation
the previous logic would have wrongly passed non-QObjects.
Member
|
I should have caught that as well, sorry about that! Thanks for the prompt follow up @pijyoi |
Contributor
Author
|
The fault is entirely mine... |
Member
"entirely": not even remotely true. You didn't press the green merge button anyway not like I haven't merged my own bugs into the repo before 😬 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#2502 introduced a bug when relaxing the test criteria for pass.
It would have passed, for example, numpy arrays that were still alive.