Fix QMenu leak in PlotItem and ViewBox#2502
Merged
j9ac9k merged 3 commits intopyqtgraph:masterfrom Oct 26, 2022
Merged
Conversation
menu.addMenu(submenu) does not take ownership of "submenu"
self.export and self.exportMethods are not assigned to, so calling either of those methods would have raised an exception.
Member
|
Thanks for the PR @pijyoi This LGTM, merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2497
QMenus are instantiated and then added to another menu as a sub-menu usingQMenu.addMenu(menu : QMenu).However, this method specifically does not take ownership of the sub-menu. (https://doc.qt.io/qt-6/qmenu.html#addMenu)
Hence the sub-menus remain parent-less.
On PySide{2,6} bindings, these parent-less sub-menus get leaked, as demonstrated by the scripts in #2497.
Setting a parent to them fixes the leak.
However, these changes cause a failure in
test_ref_cycles.py::test_PlotWidget()for PyQt{5,6} bindings.Specifically, with this change, the objects in
w.plotItem.getMenu()already have their underlying C++ object destroyed, resulting in the following error.A possible workaround (done in this PR) is to treat such occurrences as a pass.