Skip to content

Have CSV exporter export error bar information#2405

Merged
j9ac9k merged 2 commits intopyqtgraph:masterfrom
j9ac9k:add-x-and-y-errors-to-csv-exporter
Sep 5, 2022
Merged

Have CSV exporter export error bar information#2405
j9ac9k merged 2 commits intopyqtgraph:masterfrom
j9ac9k:add-x-and-y-errors-to-csv-exporter

Conversation

@j9ac9k
Copy link
Copy Markdown
Member

@j9ac9k j9ac9k commented Sep 3, 2022

This PR is a re-implementation of #1805. It allows for error bar information to be exported as part of the CSV exporter.

While working on this PR, I replaced the string-concatenation method of creating the CSV file with use of the csv module, which results in code that's much easier to read.

Fixes #1365

@j9ac9k
Copy link
Copy Markdown
Member Author

j9ac9k commented Sep 4, 2022

After sleeping on this PR and re-reviewing it. A couple of things stand-out.

  1. The export method is way too long and should be broken up into different functions.
  2. The ErrorBarItem extractor doesn't actually get the x and y positions, just the top, bottom, left and right error limits 😬

both items have been addressed now.

@j9ac9k j9ac9k force-pushed the add-x-and-y-errors-to-csv-exporter branch from 2030c21 to 0cf703d Compare September 4, 2022 04:32
@j9ac9k j9ac9k force-pushed the add-x-and-y-errors-to-csv-exporter branch from 0cf703d to 0d06a22 Compare September 4, 2022 04:55
@j9ac9k j9ac9k merged commit c964592 into pyqtgraph:master Sep 5, 2022
ntjess pushed a commit to ntjess/pyqtgraph that referenced this pull request Sep 12, 2022
* Have CSV exporter export error bar information

* Restructure CSV exporter to handle different plot types with greater ease
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error bars must be also exported with .csv export

1 participant