Merged
Conversation
94ac774 to
c37f471
Compare
The name `title` implies a string rather than a formatting callable. The intentionality behind `titleFormat` is much more explicit and doesn't clash with existing conventions for `Parameter.title()`
c37f471 to
642b9db
Compare
Member
|
Thanks for the update @ntjess LGTM, merging! |
ntjess
added a commit
to ntjess/pyqtgraph
that referenced
this pull request
Sep 7, 2022
The new example used to fail before this PR. A result of pyqtgraph#2404 was that `inspect.signature` no longer realized that `self` was a bound variable in class-defined, outside-decorated functions. Fix this simply by calling `functionToParameterDict` on the original function, rather than the interactive version.
ntjess
added a commit
to ntjess/pyqtgraph
that referenced
this pull request
Sep 7, 2022
The new example used to fail before this PR. A result of pyqtgraph#2404 was that `inspect.signature` no longer realized that `self` was a bound variable in class-defined, outside-decorated functions. Fix this simply by calling `functionToParameterDict` on the original function, rather than the interactive version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See commit messages for more information. Very minor housekeeping that is easier to perform before widespread adoption of the
Interactorfeature set