remove MatplotlibWidget from pg namespace#2400
Merged
j9ac9k merged 2 commits intopyqtgraph:masterfrom Aug 24, 2022
Merged
Conversation
Member
|
Thanks for your help debugging this and for the PR @pijyoi |
pijyoi
added a commit
to pijyoi/pyqtgraph
that referenced
this pull request
Aug 26, 2022
This reverts commit be0cbc0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR partially undoes #2366, specifically its import of
MatplotlibWidgetinto thepgnamespace.Firstly, it adds unnecessary overhead to the import of
pyqtgraphfor users who do not use the Matplotlib Exporter functionality.Secondly, this import seems to be causing the segfault in one of the CI pipelines (Python 3.9.13 / Linux / PySide2 5.15) for the not-yet-merged #2318.