Merged
Conversation
added 5 commits
April 15, 2022 08:03
This superseeds using high-quality rendering at all times, allowing the much faster cached method to be used by default, while allowing the user to not use the cache (thereby getting higher-quality output to PDF) if desired
- Document the useCache option in the PlotDataItem __init__ function and the ScatterPlotItem setData function. - Group the useCache keyword argument with other Optimization keyword arguments
…es seperately from the pen used to draw the axis/text
Member
|
Hi @ibrewster Thanks for the PR, this LGTM! |
Contributor
Author
|
Any chance of cleaning up the git log? Somehow the comments/commit messages from one of my other pull requests got in there...one of these days I'll figure out how to do this correctly! :D At least only the actual changes I wanted showed up :) |
j9ac9k
pushed a commit
to j9ac9k/pyqtgraph
that referenced
this pull request
Aug 23, 2022
* Pass the 'useCache' parameter through to ScatterPlotItem This superseeds using high-quality rendering at all times, allowing the much faster cached method to be used by default, while allowing the user to not use the cache (thereby getting higher-quality output to PDF) if desired * Add documentation - Document the useCache option in the PlotDataItem __init__ function and the ScatterPlotItem setData function. - Group the useCache keyword argument with other Optimization keyword arguments * Add tickPen/setTickPen functions to set the pen used to draw tick lines seperately from the pen used to draw the axis/text * Fix argument to setTextPen in __init__ Co-authored-by: Israel Brewster <ijbrewster@alaska.edu>
j9ac9k
pushed a commit
to j9ac9k/pyqtgraph
that referenced
this pull request
Aug 23, 2022
* Pass the 'useCache' parameter through to ScatterPlotItem This superseeds using high-quality rendering at all times, allowing the much faster cached method to be used by default, while allowing the user to not use the cache (thereby getting higher-quality output to PDF) if desired * Add documentation - Document the useCache option in the PlotDataItem __init__ function and the ScatterPlotItem setData function. - Group the useCache keyword argument with other Optimization keyword arguments * Add tickPen/setTickPen functions to set the pen used to draw tick lines seperately from the pen used to draw the axis/text * Fix argument to setTextPen in __init__ Co-authored-by: Israel Brewster <ijbrewster@alaska.edu>
j9ac9k
pushed a commit
to j9ac9k/pyqtgraph
that referenced
this pull request
Aug 24, 2022
* Pass the 'useCache' parameter through to ScatterPlotItem This superseeds using high-quality rendering at all times, allowing the much faster cached method to be used by default, while allowing the user to not use the cache (thereby getting higher-quality output to PDF) if desired * Add documentation - Document the useCache option in the PlotDataItem __init__ function and the ScatterPlotItem setData function. - Group the useCache keyword argument with other Optimization keyword arguments * Add tickPen/setTickPen functions to set the pen used to draw tick lines seperately from the pen used to draw the axis/text * Fix argument to setTextPen in __init__ Co-authored-by: Israel Brewster <ijbrewster@alaska.edu>
pijyoi
added a commit
to pijyoi/pyqtgraph
that referenced
this pull request
Aug 24, 2022
This reverts commit a392dfa.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the ability to specify the pen used to draw the axis line separately from the pen used to draw the tick marks/grid lines