Use property to lazily declare rectangle#2356
Merged
j9ac9k merged 4 commits intopyqtgraph:masterfrom Jul 13, 2022
Merged
Conversation
Contributor
|
depending on how it is used, you may add a setter |
Member
Author
Yeah I thought about that but wasn't sure what that should look like. We never supported setting your own QRectF instance, so I didn't think we should try supporting |
Member
Author
|
Now a setter is supported; I'm thinking that in a future PR we will want to deprecate |
pijyoi
reviewed
Jul 11, 2022
45e6a31 to
aa456d5
Compare
Contributor
|
Thanks for this. It seems to work with our code base and looks like a good solution. |
Member
Author
|
Thanks for checking @markotoplak ! |
j9ac9k
added a commit
to j9ac9k/pyqtgraph
that referenced
this pull request
Aug 23, 2022
* Use property to lazily declare rectangle
j9ac9k
added a commit
to j9ac9k/pyqtgraph
that referenced
this pull request
Aug 23, 2022
* Use property to lazily declare rectangle
j9ac9k
added a commit
to j9ac9k/pyqtgraph
that referenced
this pull request
Aug 23, 2022
* Use property to lazily declare rectangle
j9ac9k
added a commit
to j9ac9k/pyqtgraph
that referenced
this pull request
Aug 23, 2022
* Use property to lazily declare rectangle
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2352
This PR redoes #2168 in a way that we hope should make everyone happy. Thank you to @ksunden 's suggestion here for a good way of going about it.
@markotoplak @danielhrisca Please take the opportunity to test this branch and see if this works for your use-case.
Thanks!