Apply the log mode to the displayed dataset, export the mapped one#2188
Closed
StSav012 wants to merge 1 commit intopyqtgraph:masterfrom
Closed
Apply the log mode to the displayed dataset, export the mapped one#2188StSav012 wants to merge 1 commit intopyqtgraph:masterfrom
StSav012 wants to merge 1 commit intopyqtgraph:masterfrom
Conversation
My next try to export the actual data plotted in log mode. It should be pyqtgraph#2187. I believe that the log mode is something of displaying, not of the actual data. So, I moved the `applyLogMapping` function call down to `self._datasetDisplay`. Next, I return the data saved into `self._datasetMapped` in `PlotDataItem.getData` function. It's a kind of expected behavior when it comes to returning the data, not the position of screen points. I realize that it better be two tiny commits.
Contributor
Author
|
The tests don't seem to be adequate. My code is fine, the tests are not. Please take a look at the tests. The test do expect the data to change when the log mode is on. I contradict the behavior. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My next try to export the actual data plotted in log mode. That's what #2187 should have been.
I believe that the log mode is something of displaying, not of the actual data. So, I moved the
applyLogMappingfunction call down toself._datasetDisplay.Next, I return the data saved into
self._datasetMappedinPlotDataItem.getDatafunction. It's a kind of expected behavior when it comes to returning the data, not the position of screen points.I realize that it better be two tiny commits.