Merged
Conversation
Member
|
LGTM, thanks @NilsNemitz ! |
ntjess
pushed a commit
to ntjess/pyqtgraph
that referenced
this pull request
Dec 10, 2021
* Fix permanent collision signal due rounding * add additional insurance against false detection of full region move
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This address #2102:
The test case there (Thank you @pijyoi!) triggers a case I had not considered in the range adjustment code of ColorBarItem:
Result:
The top end of the range is detected out of range and corrected down, but restored to the original value by rounding.
This is (continuously) interpreted as both top and bottom end moving, a "region move" normally triggered by dragging the center of the bar.
In that case, the previous size of the region is held fixed to avoid squishing the range against the top or bottom limit.
Which is the bug encountered in #2102 : The region actively resists any attempt to make it smaller.
This PR
I hope that eliminates the issue in the future and closes #2102