Convert == None checks to is None#2099
Merged
j9ac9k merged 2 commits intopyqtgraph:masterfrom Nov 15, 2021
Merged
Conversation
Member
|
There are a few places in the repo we have I see two instances in |
Contributor
Author
|
The ROI ones were addressed by #2095 |
Contributor
Author
|
I do not care about the exception one, I think its current state is readable and gets the point across, and if anything changing it would be less readable in this case. |
Member
|
That's legit, LGTM, another PR can capture the |
ntjess
pushed a commit
to ntjess/pyqtgraph
that referenced
this pull request
Dec 10, 2021
* Convert == None checks to is None * test_dock instance of != None
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.