Skip to content

Remove polluting imports using *#2098

Merged
j9ac9k merged 2 commits intopyqtgraph:masterfrom
ksunden:polluting-import
Nov 15, 2021
Merged

Remove polluting imports using *#2098
j9ac9k merged 2 commits intopyqtgraph:masterfrom
ksunden:polluting-import

Conversation

@ksunden
Copy link
Copy Markdown
Contributor

@ksunden ksunden commented Nov 15, 2021

Define __all__ on additional files

Define `__all__` on additional files
Had been inherited by splat import via Node, which just imported it
@j9ac9k
Copy link
Copy Markdown
Member

j9ac9k commented Nov 15, 2021

Thanks @ksunden LGTM, merging.

@j9ac9k j9ac9k merged commit f399811 into pyqtgraph:master Nov 15, 2021
ntjess pushed a commit to ntjess/pyqtgraph that referenced this pull request Dec 10, 2021
* Remove polluting imports using \*

Define `__all__` on additional files

* GraphicsObject needs to be imported in Flowchart.py

Had been inherited by splat import via Node, which just imported it
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants