update imports in the broken example demos#2087
Merged
j9ac9k merged 3 commits intopyqtgraph:masterfrom Nov 14, 2021
Wubbzi:exampleImports
Merged
update imports in the broken example demos#2087j9ac9k merged 3 commits intopyqtgraph:masterfrom Wubbzi:exampleImports
j9ac9k merged 3 commits intopyqtgraph:masterfrom
Wubbzi:exampleImports
Conversation
…lativity, and verlet_chain demos
Member
|
Hi @Wubbzi Thanks for the PR! I know I suggested this fix on the discord, but after taking a closer look, I believe there is a better fix. Specifically in this line: https://github.com/pyqtgraph/pyqtgraph/blob/master/pyqtgraph/examples/ExampleApp.py#L484 We should replace Would you mind undoing the changes in this PR, and modify that subprocess call instead? |
…bprocess.Popen call when an edited file is run.
Member
|
Thank you @Wubbzi ! |
ntjess
pushed a commit
to ntjess/pyqtgraph
that referenced
this pull request
Dec 10, 2021
change path of the current working directory that is passed to the subprocess.Popen call when an edited file is run.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.