Fix parametertree name/title handling#1356
Merged
j9ac9k merged 1 commit intopyqtgraph:masterfrom Oct 27, 2020
Merged
Conversation
Member
campagnola
commented
Sep 3, 2020
- Parameters now respond to title change in setOpts
- Add Parameter.title()
- Action parameter uses default name/title handling in addition to setting button text (fixes Bug: ActionParameter.hide() causes rename to empty string #1320)
- Parameters now respond to title change in setOpts - Add Parameter.title() - Action parameter uses default name/title handling in addition to setting button text (fixes pyqtgraph#1320)
Member
Author
2xB
approved these changes
Sep 4, 2020
Contributor
2xB
left a comment
There was a problem hiding this comment.
To me, solving this by deleting
self.setText(0, '')in ActionParameterItem.__init__ also looks like the proper solution. Further this looks like a good cleanup! Renaming ActionParameterItem.paramRenamed to .titleChanged slightly changes the API, but this is easy-to-spot and probably causes only niche issues.
Contributor
|
@campagnola Reviewing this PR, I stumbled across the unused |
Contributor
|
Reviewed and tested. Looks good to me. |
Member
|
LGTM, merging, sorry for the delay on this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.