Skip to content

Bugfix for issue #1320 : Fix for ActionParameterItem name changing to empty string when hidden#1350

Closed
meganbkratz wants to merge 1 commit intopyqtgraph:masterfrom
meganbkratz:paramtreefix
Closed

Bugfix for issue #1320 : Fix for ActionParameterItem name changing to empty string when hidden#1350
meganbkratz wants to merge 1 commit intopyqtgraph:masterfrom
meganbkratz:paramtreefix

Conversation

@meganbkratz
Copy link
Copy Markdown
Contributor

This is a fix for issue #1320

@campagnola
Copy link
Copy Markdown
Member

The fix here looks fragile to me--it relies on ignoreNameColumnChange always being True, which should not be relied on since that variable is being used for other purposes. There are a few other problems surrounding this issue as well, which should be addressed in #1356.

@meganbkratz
Copy link
Copy Markdown
Contributor Author

Thank you for figuring out how to fix this better!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants