Fix incorrect rendering of overlapping object in renderToArray()#1306
Merged
j9ac9k merged 1 commit intopyqtgraph:masterfrom Oct 14, 2020
Merged
Conversation
This commit adds a depth buffer in renderToArray(). This fixes the issue that overlapping objects are rendered incorrectly when using renderToArray() on a GLViewWidget. This might be related to issue pyqtgraph#743.
Member
|
Thanks for the PR @ahendriksen sorry it's taken us so long to follow up with you. The changes look good to me; merging. |
Contributor
Author
|
Fantastic! Thanks for merging, and thanks for the wonderful package! |
dgoeries
pushed a commit
to dgoeries/pyqtgraph
that referenced
this pull request
Oct 14, 2020
…tgraph#1306) This commit adds a depth buffer in renderToArray(). This fixes the issue that overlapping objects are rendered incorrectly when using renderToArray() on a GLViewWidget. This might be related to issue pyqtgraph#743.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds a depth buffer in renderToArray().
This fixes the issue that overlapping objects are rendered incorrectly
when using renderToArray() on a GLViewWidget.
This might be related to issue #743.