Skip to content

Refactored the codebase#655

Merged
agronholm merged 8 commits intomainfrom
big-refactoring
Mar 28, 2025
Merged

Refactored the codebase#655
agronholm merged 8 commits intomainfrom
big-refactoring

Conversation

@agronholm
Copy link
Copy Markdown
Contributor

@agronholm agronholm commented Mar 26, 2025

  • Dropped the bdist_wheel implementation, left a compatibility shim to import it from setuptools or, if that fails, raise a human-readable ImportError
  • Replaced vendored packaging with a run-time dependency on it
  • Dropped support for Python 3.8
  • Made wheel.metadata private (but allowed import with a deprecation warning)
  • Made wheel.cli private
  • Added missing type annotations
  • Migrated to native TOML tox configuration
  • Test the CLI using subprocess calls
  • Added Python 3.14 to the test matrix

* Dropped bdist_wheel along with its entry point and related code
* Replaced vendored "packaging" with a run-time dependency on it
* Dropped support for Python 3.8
* Made "wheel.metadata" private (but allowed import with a deprecation warning)
* Made "wheel.cli" private
* Added missing type annotations
* Migrated to native TOML tox configuration
* Test the CLI using subprocess calls
* Added Python 3.14 to the test matrix
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 26, 2025

Codecov Report

Attention: Patch coverage is 89.70588% with 14 lines in your changes missing coverage. Please review.

Project coverage is 93.20%. Comparing base (374c402) to head (3256879).
Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
src/wheel/_metadata.py 92.39% 7 Missing ⚠️
src/wheel/__main__.py 0.00% 5 Missing ⚠️
src/wheel/bdist_wheel.py 66.66% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #655       +/-   ##
===========================================
+ Coverage   78.25%   93.20%   +14.95%     
===========================================
  Files          14       11        -3     
  Lines        1122      633      -489     
===========================================
- Hits          878      590      -288     
+ Misses        244       43      -201     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@agronholm
Copy link
Copy Markdown
Contributor Author

Coverage computation is a bit of an issue with the subprocess approach.

bwoodsend added a commit to bwoodsend/pyinstaller that referenced this pull request Mar 28, 2025
The `wheel.bdist_wheel` module has moved into setuptools. The former is
being removed, albeit with a deprecated `from
setuptools.command.bdist_wheel import bdist_wheel` compatibility shim in
its place.

See: pypa/wheel#655
@agronholm agronholm merged commit a99cdd5 into main Mar 28, 2025
18 checks passed
@agronholm agronholm deleted the big-refactoring branch March 28, 2025 10:42
bwoodsend added a commit to bwoodsend/pyinstaller that referenced this pull request Mar 29, 2025
The `wheel.bdist_wheel` module has moved into setuptools. The former is
being removed, albeit with a deprecated `from
setuptools.command.bdist_wheel import bdist_wheel` compatibility shim in
its place.

See: pypa/wheel#655
bwoodsend added a commit to pyinstaller/pyinstaller that referenced this pull request Mar 29, 2025
The `wheel.bdist_wheel` module has moved into setuptools. The former is
being removed, albeit with a deprecated `from
setuptools.command.bdist_wheel import bdist_wheel` compatibility shim in
its place.

See: pypa/wheel#655
abravalheri pushed a commit to abravalheri/setuptools that referenced this pull request Apr 28, 2025
* Dropped the `bdist_wheel` implementation, left a compatibility shim to import it from `setuptools.command.bdist_wheel` or, if that fails, raise a human-readable `ImportError`
* Replaced vendored `packaging` with a run-time dependency on it
* Dropped support for Python 3.8
* Made `wheel.metadata` private (but allowed import with a deprecation warning)
* Made `wheel.cli` private
* Added missing type annotations
* Migrated to native TOML tox configuration
* Test the CLI by invoking the `main()` function instead of individual command functions, thus exercising the argument parser
* Added Python 3.14 to the test matrix
* Used relative imports wherever possible
dalcinl added a commit to mpi4py/mpi4py that referenced this pull request Jan 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants