Apply a few suggestions from refurb#2647
Closed
DimitriPapadopoulos wants to merge 1 commit intopypa:mainfrom
DimitriPapadopoulos:refurb
Closed
Apply a few suggestions from refurb#2647DimitriPapadopoulos wants to merge 1 commit intopypa:mainfrom DimitriPapadopoulos:refurb
DimitriPapadopoulos wants to merge 1 commit intopypa:mainfrom
DimitriPapadopoulos:refurb
Conversation
These appear to improve readability.
gaborbernat
requested changes
Sep 23, 2023
Contributor
gaborbernat
left a comment
There was a problem hiding this comment.
I don't agree with most of these .
Contributor
Author
Why?
|
esafak
pushed a commit
to esafak/virtualenv
that referenced
this pull request
Aug 1, 2025
The cache for PythonInfo is now invalidated if the PythonInfo class changes. I achieved this by hashing the py_info.py file and storing the hash in the cache. When loading from the cache, the hash is recomputed and compared with the stored hash. If they don't match, the cache is invalidated. Fixes pypa#2647
esafak
pushed a commit
to esafak/virtualenv
that referenced
this pull request
Aug 1, 2025
The cache for PythonInfo is now invalidated if the PythonInfo class changes. I achieved this by hashing the py_info.py file and storing the hash in the cache. When loading from the cache, the hash is recomputed and compared with the stored hash. If they don't match, the cache is invalidated. Fixes pypa#2647 Signed-off-by: Emre Şafak <3928300+esafak@users.noreply.github.com>
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These refurb suggestions appear to improve readability.
The changes seem trivial to me, hence the lack of news fragment.
Thanks for contributing, make sure you address all the checklists (for details on how see development documentation)
tox -e fix)docs/changelogfolder