Address circular imports complaints by Sphinx 7.2+#4023
Merged
abravalheri merged 5 commits intopypa:mainfrom Aug 23, 2023
Merged
Address circular imports complaints by Sphinx 7.2+#4023abravalheri merged 5 commits intopypa:mainfrom
abravalheri merged 5 commits intopypa:mainfrom
Conversation
henryiii
added a commit
to scikit-build/scikit-build-core
that referenced
this pull request
Aug 21, 2023
Temporary fix while waiting for pypa/setuptools#4023. Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
henryiii
pushed a commit
to scikit-build/scikit-build-core
that referenced
this pull request
Aug 21, 2023
pypa/setuptools#4023 Fixes the issue Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
Somehow before this change the tests were failing because the ``Version`` class imported in the tests was different from the ``Version`` class produced in the code under test.
cbedc26 to
0cf5182
Compare
Contributor
Author
|
Since the problem with sphinx seems to be impacting other users, I will go ahead and merge this as soon as the CI is green (but I will not immediately publish a new release). Hopefully it is just some refactoring that does not impact negatively the project. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
The latest version of
sphinxstarted failing in #4020 (comment) due to circular imports.Examples of the error messages are:
In this PR, I am attempting to address this problem.
The approach I used was:
setuptools/__init__.py,setuptools/monkey.pyandsetuptools/dist.pyto avoid circular imports.import ...andfrom ... import ...statements, etc)setuptools.extern.packagingandsetuptools/depends.pyandsetuptools/tests/test_setuptools.pybecause for some reason the tests where complaining that theVersionclass was differing from itself (maybe the module is loaded twice?)Closes
Pull Request Checklist
newsfragments/.(See documentation for details)