Skip to content

Merge with pypa/distutils@152c13d#3430

Merged
jaraco merged 8 commits intomainfrom
feature/distutils-152c13d
Jul 4, 2022
Merged

Merge with pypa/distutils@152c13d#3430
jaraco merged 8 commits intomainfrom
feature/distutils-152c13d

Conversation

@jaraco
Copy link
Copy Markdown
Member

@jaraco jaraco commented Jul 4, 2022

Summary of changes

Closes

Pull Request Checklist

lazka and others added 8 commits June 8, 2022 21:07
On Windows there is nothing like rpath, so when CygwinCCompiler()
tries to link it will assume unix and pass rpath flags to the linker,
which will fail.

In cygwin this is currently patched away:
https://cygwin.com/git-cygwin-packages/?p=git/cygwin-packages/python39.git;a=blob;f=3.1-enable-new-dtags.patch;h=716af3b14d3483e5a4
It is taking some macos fallback branch that is equal to library_dirs, which doesn't add much if
library_dirs is set, so in theory it should just return [] there.

This patch tries to bring it a bit closer to MSVCCompiler() which warns if
runtime_library_dirs is passed and raises if runtime_library_dir_option() is
called.

In the case of cygwin we only warn if runtime_library_dir_option() is called and return
nothing, so runtime_library_dirs is ignored. It's debatable if it should fail here,
but since cygwin is used to build unix software that might not be aware of this limitation
a warning seems more fitting.

In the mingw case we assume the user knows that they are targeting Windows and so we can be
more strict and error out like MSVCCompiler().

In both cases we warn if runtime_library_dirs is passed to the compiler, like with MSVC.
Remove warning about packages not containing `__init__.py` files
Improve handling if runtime_library_dirs is set with cygwin/mingw
Add support for Homebrew on Python 3.9
@jaraco jaraco force-pushed the feature/distutils-152c13d branch from 8623243 to cd62fb6 Compare July 4, 2022 00:18
@jaraco jaraco merged commit db66bd0 into main Jul 4, 2022
@jaraco jaraco deleted the feature/distutils-152c13d branch July 4, 2022 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Homebrew/framework install scheme not honored for scripts

3 participants