Conversation
jmarshall
reviewed
Sep 9, 2021
jaraco
reviewed
Sep 12, 2021
Contributor
|
There are users (like us) that are still using bdist_rpm to create rpms. I don't really understand the rational behind removing |
5 tasks
d-fence
added a commit
to odoo-dev/odoo
that referenced
this pull request
Feb 16, 2022
The rpm package failed recently on a file name containing a space. This issue is fixed by protecting file names with double quotes in the installed files list. Also, during this fix, it was discovered that the bdist_rpm is deprecated in setuptools [0]. For that reason, the rpm is now generated from the package.py script. [0] pypa/setuptools#2780
robodoo
pushed a commit
to odoo/odoo
that referenced
this pull request
Feb 16, 2022
The rpm package failed recently on a file name containing a space. This issue is fixed by protecting file names with double quotes in the installed files list. Also, during this fix, it was discovered that the bdist_rpm is deprecated in setuptools [0]. For that reason, the rpm is now generated from the package.py script. [0] pypa/setuptools#2780 closes #84665 Signed-off-by: Christophe Monniez (moc) <moc@odoo.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Similar to #2040, deprecate
bdist_rpm.For #1988.
Also some test/CI improvements (please let me know if these should be in another PR):
Pull Request Checklist
changelog.d/.(See documentation for details)