Fix pipe reading hanging indefinitely on Windows#756
Merged
Conversation
Member
|
I'm acknowledging this PR so you know I'm not ignoring it, but JFYI: I'm pretty backlogged at the moment, so I can't guarantee a timely review here 🙂 |
Member
|
Took a look, and I have no major objection to removing the explicit buffer sizes. That being said, it'd be ideal to have a better understanding of why this would deadlock on Windows: we set |
woodruffw
approved these changes
Apr 12, 2024
woodruffw
added a commit
that referenced
this pull request
Apr 12, 2024
Signed-off-by: William Woodruff <william@trailofbits.com>
3 tasks
woodruffw
added a commit
that referenced
this pull request
Apr 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While doing tests with pip-audit, I noticed several times the process stalling while installing the isolated env.
By removing the stdout/stderr read size, it seems to run properly, however it's quite tricky to reproduce.