Fix installation of wheel with non-ASCII entries#8223
Conversation
|
Oh wow, it seems like flake8 just released a new version, and the new rules borked all our linting jobs. |
|
We should scream at them, so they can tell us we should have pinned our dependency and done a more controlled rollout of the new version 🙂 Seriously we should pin for now, and discuss the new rules. I'm not sure I want to just knee-jerk "fix" the failures here (why shouldn't we call a variable in a comprehension "l" for a line?). |
|
Fix merged. :) Rebasing on master will make the warnings vanish! :) |
So... The issue was the flake8 started providing it's pre-commit hook properly, and we needed to update to use those instead of a deprecated hook. #8227 did that. :) |
Thank you, thank you for saying that! Regarding checks, one possible thing to check for would be that abugidas can be well represented. Because of a bug in I am not sure how the new tests were implemented here, but would it be possible to include testing for modules with the following names? Even if
Thanks! |
|
Let me use |
|
@uranusjr FYI: This needs a rebase. |
This mainly deals with correctly recording the wheel content in the RECORD metadata. This metadata file must be written in UTF-8, but the actual files need to be installed to the filesystem, the encoding of which is not (always) UTF-8. So we need to carefully handle file name encoding/decoding when comparing RECORD entries to the actual file. The fix here makes sure we always use the correct encoding by adding strict type hints. The entries in RECORD is decoded/encoded with UTF-8 on the read/write boundaries to make sure we always deal with text types. A type-hint-only type RecordPath is introduced to make sure this is enforced (because Python 2 "helpfully" coerces str to unicode with the wrong encoding).
This mainly deals with correctly recording the wheel content in the RECORD metadata. This metadata file must be written in UTF-8, but the actual files need to be installed to the filesystem, the encoding of which is not (always) UTF-8. So we need to carefully handle file name encoding/decoding when comparing RECORD entries to the actual file.
The fix here makes sure we always use the correct encoding by adding strict type hints. The entries in RECORD is decoded/encoded with UTF-8 on the read/write boundaries to make sure we always deal with text types. A type-hint-only type RecordPath is introduced to make sure this is enforced (because Python 2 "helpfully" coerces str to unicode with the wrong encoding).
Close #7138, close #7574.