Fix Unicode issues in pip install (try 2)#7574
Conversation
|
So it seems |
|
Let's rebase this today, and see if more issues prop up. : |
Co-authored-by: Julien Malard <julien.malard@mail.mcgill.ca>
So installing from source means we need setuptools to also correctly open csv. Will need to file a PR for that to make this work.
0b5dd19 to
ce5c127
Compare
This conveys the semantic meanings better, and let us include less-generic logic in the function, e.g. always opening with UTF-8.
4c8414f to
e32919e
Compare
A link is added to the news fragment pointing to the corresponding setuptools bug.
Passing in a Unicode
|
Everything is terrible and I doubt my life choices. Seriously asking: Can we let non-ASCII file names remain broken on Python 2, and fix this only for Python 3? |
Honestly, I'd be fine with this, One of the major reasons for the Python 3 compatibility break was to allow us to have sane Unicode handling, so "sorry, but you need Python 3 if you want proper Unicode support" seems a completely reasonable stance for us to take IMO. @pypa/pip-committers does anyone have a problem with this? |
|
I'm 100% on board. |
|
Hello! I am an automated bot and I have noticed that this pull request is not currently able to be merged. If you are able to either merge the |
Supersedes and closes #7138. Any suggestion on how to improve the test cases (check that files are actually installed and recorded correctly, probably) would be much welcomed.
I also included an xfail test for installing from source. It fails right now because Setuptools has the exact same problem generating the record for egg-info. Need to fix that as well. See pypa/setuptools#1399.