Updated sphinx to 2.4.0#7720
Merged
pradyunsg merged 3 commits intopypa:masterfrom Feb 28, 2020
RDIL:patch-1
Merged
Conversation
Member
Contributor
Author
|
Done @webknjaz! |
webknjaz
approved these changes
Feb 11, 2020
pradyunsg
reviewed
Feb 11, 2020
pradyunsg
approved these changes
Feb 11, 2020
Member
|
Closed and reopened, to retrigger CI. |
Member
|
The CI failure does not seem to be related to the change in the PR. Maybe rebase it. |
Co-Authored-By: Pradyun Gedam <pradyunsg@gmail.com>
Contributor
Author
|
Oh no I think I messed the rebase up |
Contributor
Author
|
Never mind, its properly rebased now |
Member
|
@pradyunsg it's ready |
Member
|
Triggering CI again in the mean time. I want at least ReadTheDocs to pass since this is a change to the documentation toolchain. |
Contributor
Author
|
Everything is passing |
Member
|
That took a bit of time! Thanks @RDIL for persisting and helping make sure that this gets done! |
Contributor
Author
|
No problem, just don't forget about #7767 since its also passing 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
News fragment not needed
Fixes #7130