Added copyright doc#7767
Merged
pradyunsg merged 5 commits intopypa:masterfrom Mar 18, 2020
RDIL:copyright-docs
Merged
Conversation
Signed-off-by: Reece Dunham <me@rdil.rocks>
Signed-off-by: Reece Dunham <me@rdil.rocks>
pradyunsg
reviewed
Feb 22, 2020
Member
pradyunsg
left a comment
There was a problem hiding this comment.
LGTM, barring one minor comment.
Co-Authored-By: Pradyun Gedam <pradyunsg@gmail.com>
pradyunsg
approved these changes
Feb 22, 2020
pradyunsg
reviewed
Feb 22, 2020
Member
pradyunsg
left a comment
There was a problem hiding this comment.
Hmm... Looks like the documentation build is failing because the copyright page isn't actually referenced directly anywhere.
Could you add a :orphan: on a separate line on the top?
Basically:
:orphan:
=====
Contributor
Author
|
Fixed, and all the docs related builds are passing! |
Member
|
Awesome! Looks like the failures are unrelated to this PR! I'll take a look at them in a bit. :) |
webknjaz
reviewed
Feb 29, 2020
pradyunsg
approved these changes
Mar 18, 2020
Member
|
Awesome! Thanks @RDIL! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Reece Dunham me@rdil.rocks
fixes #7464