Fix issue #131 - Please add status command#664
Fix issue #131 - Please add status command#664carljm merged 7 commits intopypa:developfrom rafaelcaricio:develop
Conversation
|
+1 Looks good |
|
Just as a note: the initial patch was made by @kelseyhightower, not @vbabiy. @vbabiy just migrated pip's issues from Bitbucket to Github (that's why his nick appears as author). |
There was a problem hiding this comment.
Isn't this assert wrong? Shouldn't it be:
assert 'Location: %s' % dist.location == lines[3]
|
I'm sure there could be bikeshedding of the command name and whether it should be part of a larger Thanks @kelseyhightower for the original work and @rafaelcaricio for adding tests! |
|
@jezdez Nothing in your proposal on #235 for a In any case, I think we need to put higher priority on "whoever builds the bikeshed gets to paint it", or else useful features just stall forever, get out of date, need to be rebased, etc. If there's a contribution that works, has tests, and is useful (like this one), I think we should err on the side of merging it sooner rather than later. If someone wants to bikeshed the name etc, they can make their own subsequent contribution of actual code to do that before it is released. |
|
@hltbra Wow, nice to see this finally get merged! |
|
@carljm Oh, true indeed, that was completely different. I wish there wouldn't be another generic subcommand though --"status" and "list" both are pretty ambiguous terms. I would have preferred to have a discussion about those commands again since when @kelseyhightower wrote that end of 2010 we certainly had different plans for pip than now. Regarding the bikeshedding, I strongly disagree that a working patch and tests is enough to add a feature. This is plain and simple the road to feature creep and an unneeded burden to our already strained time resources. Note, I also very much dislike seeing contributions going stale but I often have regretted adding a feature without having it discussed or thought through before. If it's not obvious, my opinion isn't meant to be a blow at @kelseyhightower's or @rafaelcaricio's contribution, on the contrary I just want to make sure your contribution is a good as possible and then a bit more. |
|
@jezdez Ok, I think we can easily compromise re approach to merge - in the future I'll highlight you first and ask your opinion. It's particularly tempting to merge quickly when at a sprint and working with the contributor in person :-) Re the specifics here, I do wonder whether |
|
@carljm Understood, and totally agreed about sprints :)
|
Mostly code made by @vbabiy with some modifications and tests. Fix issue #131.